Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add requireVerifiedChromeOs as optional #4758

Merged
merged 2 commits into from
May 4, 2021
Merged

add requireVerifiedChromeOs as optional #4758

merged 2 commits into from
May 4, 2021

Conversation

keeleysam
Copy link
Contributor

@keeleysam keeleysam commented May 3, 2021 •
edited by slevenick
Loading

Adds support for requireVerifiedChromeOs in basic access levels, please see https://cloud.google.com/access-context-manager/docs/access-level-attributes.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

accesscontextmanager: added support for `require_verified_chrome_os` in basic access levels.

@google-cla google-cla bot added the cla: yes label May 3, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician modular-magician requested a review from slevenick May 3, 2021 16:27
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 27 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 28 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
Inspec: Diff ( 2 files changed, 5 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185482"

slevenick
slevenick requested changes May 3, 2021
View reviewed changes
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that specifies this field on this resource? I think it would go here:
https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/tests/resource_access_context_manager_access_levels_test.go

Or at least specify this field on an existing test so we can make sure it works!

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185488"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 29 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 29 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))
Inspec: Diff ( 2 files changed, 5 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185506"

@keeleysam
Copy link
Contributor Author

@slevenick I added it to a couple of tests

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185509"

@slevenick slevenick self-requested a review May 4, 2021 16:22
slevenick
slevenick approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slevenick slevenick merged commit accdeca into GoogleCloudPlatform:master May 4, 2021
@keeleysam keeleysam deleted the patch-15 branch May 4, 2021 16:25
@keeleysam keeleysam mentioned this pull request May 4, 2021
Merged
5 tasks
This was referenced May 4, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keeleysam @modular-magician @slevenick